Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for tuples in option checking. Fixes #3303 #3381

Closed
wants to merge 1 commit into from
Closed

Added support for tuples in option checking. Fixes #3303 #3381

wants to merge 1 commit into from

Conversation

aryan1165
Copy link

@aryan1165 aryan1165 commented Sep 29, 2023

Description

Earlier:
Screenshot 2023-09-29 at 9 24 25 PM

Earlier "particle size" was not treated as a tuple and this caused problem as explained in Issue #3303.

Now:

Screenshot 2023-09-29 at 9 33 27 PM

Now, there is added compatibility for "particle size" to be either a tuple or a single value.

Fixes #3303

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

@kratman
Copy link
Contributor

kratman commented Sep 29, 2023

This seems to be the same as PR #3342

@aryan1165 aryan1165 closed this Sep 29, 2023
@aryan1165 aryan1165 deleted the fixes_#3303 branch September 29, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better option checking
2 participants