Skip to content

Commit

Permalink
Preserve direction in valves so we could migrate these back in the fu…
Browse files Browse the repository at this point in the history
…ture
  • Loading branch information
notnotmelon committed Oct 19, 2024
1 parent d455c09 commit 2337864
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 7 additions & 7 deletions prototypes/buildings/valves/overflow-valve.lua
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ITEM {

ENTITY {
name = "py-overflow-valve",
type = "simple-entity-with-owner",
type = "storage-tank",
minable = {mining_time = 1, result = "py-overflow-valve"},
icon = "__pyindustry__/graphics/icons/overflow-valve.png",
icon_size = 32,
Expand All @@ -48,24 +48,24 @@ ENTITY {
base_level = 0.8,
pipe_covers = _G.pipecoverspictures(),
pipe_connections = {
{
--[[{
position = {0, 0},
direction = defines.direction.south,
-- flow_direction = "output" --TODO fix valves
},
{
position = {0, -0},
direction = defines.direction.north
}
}--]]
}
},
pictures = {
--[[gas_flow = py.empty_image(),
gas_flow = py.empty_image(),
fluid_background = py.empty_image(),
window_background = py.empty_image(),
flow_sprite = py.empty_image(),
picture = {--]]
layers = {
picture = {
sheets = {
{
filename = "__pyindustry__/graphics/entity/py-valves/hr-overflow-valve.png",
priority = "extra-high",
Expand Down Expand Up @@ -95,7 +95,7 @@ ENTITY {
scale = 0.5
}
}
--}
}
},
circuit_wire_connection_points = {
{
Expand Down
14 changes: 7 additions & 7 deletions prototypes/buildings/valves/underflow-valve.lua
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ITEM {

ENTITY {
name = "py-underflow-valve",
type = "simple-entity-with-owner",
type = "storage-tank",
minable = {mining_time = 1, result = "py-underflow-valve"},
icon = "__pyindustry__/graphics/icons/overflow-valve.png",
icon_size = 32,
Expand All @@ -48,24 +48,24 @@ ENTITY {
base_level = -0.2,
pipe_covers = _G.pipecoverspictures(),
pipe_connections = {
{
--[[{
position = {0, 0},
direction = defines.direction.south
},
{
position = {0, -0},
direction = defines.direction.north,
-- flow_direction = "output" --TODO fix valves
}
}--]]
}
},
pictures = {
--[[gas_flow = py.empty_image(),
gas_flow = py.empty_image(),
fluid_background = py.empty_image(),
window_background = py.empty_image(),
flow_sprite = py.empty_image(),
picture = {--]]
layers = {
picture = {
sheets = {
{
filename = "__pyindustry__/graphics/entity/py-valves/hr-underflow-valve.png",
priority = "extra-high",
Expand All @@ -86,7 +86,7 @@ ENTITY {
scale = 0.5
}
}
--}
}
},
circuit_wire_connection_points = {
{
Expand Down

0 comments on commit 2337864

Please sign in to comment.