[WIP] Caravan circuit improvments #292
Merged
+43
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm working towards improving the circuit conditions in caravans. Before I get too far, (and because I'm bad at LUA) I wanted to start a PR for feedback.
At the moment, this adds a "circuit condition with static value" option to caravans, to allow checking if "=" a value, rather than another signal. As far as I can tell, the nice circuit gui dialog that the base game has cannot be reused by mods, so this seemed like the cleanest solution, but I might be missing something.
I'd like to also add support for a wider range of conditions, not just "=". I'm not exactly sure the best way to do this. My thought is to make a circuit condition class that encapsulates the conditions and conditionals, and exposes an evaluate method, but I'm not sure exactly where to stick this class, or if theres a simpler way I'm missing.
I'll keep poking at my ideas, but would appreciate some feedback before I go too far down a road.