Fixed a crash when reverting a TURD that changes a machine.

Resolves pyanodon/pybugreports#736
pyanodon · Dec 21, 2024 · bab6ad4 · bab6ad4
1 parent 1e6d9a7
commit bab6ad4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.txt b/changelog.txt
@@ -6,9 +6,10 @@ Date: ?
     - Greatly increased the science pack requirement for the wood processing unit turd from 500 -> 7000. Resolves https://github.com/pyanodon/pybugreports/issues/758
     - Fix the base productivity on Composter from Composter TURD path 2.
     - All caravans can use all caravan outpost types
-    - Fixed picked TURDs appearing to be re-pickable when they were not. Resolves https://github.com/pyanodon/pybugreports/issues/769
   TURD:
-    - Redid bioreactor turd entirely.
+    - Redid bioreactor TURD entirely.
+    - Fixed a crash when reverting a TURD that changes a machine. Resolves https://github.com/pyanodon/pybugreports/issues/736
+    - Fixed picked TURDs appearing to be re-pickable when they were not. Resolves https://github.com/pyanodon/pybugreports/issues/769
 ---------------------------------------------------------------------------------------------------
 Version: 3.0.31
 Date: 2024-11-29

diff --git a/scripts/turd/turd.lua b/scripts/turd/turd.lua
@@ -428,10 +428,10 @@ local function unselect_recipes_for_subtech(sub_tech, force, assembling_machine_
 				recipe_replacement(recipe, effect.old and recipes[effect.old], force, assembling_machine_list)
 			end
 		elseif effect.type == "machine-replacement" then
-			assembling_machine_list = machine_replacement(effect.new, effect.old, assembling_machine_list)
 			if storage.turd_machine_replacements[force.index] then
 				storage.turd_machine_replacements[force.index][effect.old] = nil
 			end
+			assembling_machine_list = machine_replacement(effect.new, effect.old, assembling_machine_list)
 		end
 	end
 end