Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributors.yml #530

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Update contributors.yml #530

merged 3 commits into from
Nov 22, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 22, 2024

@@ -7692,3 +7692,31 @@
- stingray
location: Cambridge, MA
email:
- name: Carlos Ramos Carreño
github_username: vnmabus
github_image_id:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what image ID is or how to get it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot can do that for you OR if you right click on the user's profile - you get a url like the one before for Carlos.
https://avatars.githubusercontent.com/u/2364173?v=4

2364173 is the id ! the bot will grab that as long as we have a github username in the file.

@pllim pllim marked this pull request as ready for review November 22, 2024 14:36
lwasser
lwasser previously approved these changes Nov 22, 2024
_data/contributors.yml Outdated Show resolved Hide resolved
@lwasser
Copy link
Member

lwasser commented Nov 22, 2024

@pllim, what I am going to do today is set up a test workflow just like the one we have here in our pyometra repo that runs off of the main branch!! That way we can look at the state of the files before i push a release to make sure we are happy with everything. THANK YOU for this per!! let's merge once CI is semi happy. Can I add you to the team that has merge rights for this repo and a few others?

you don't have to use them if you dont want but it seems like it would be good for you to have them 🚀

@lwasser
Copy link
Member

lwasser commented Nov 22, 2024

the errors in CI are because of htat weird zenodo issue that we are working on!

@lwasser lwasser merged commit b7803e3 into pyOpenSci:main Nov 22, 2024
3 of 4 checks passed
@pllim pllim deleted the patch-2 branch November 22, 2024 19:19
@pllim
Copy link
Contributor Author

pllim commented Nov 22, 2024

Can I add you to the team that has merge rights

I am not sure if I am ready, so no thanks. I am not yet well versed enough in your project's infrastructure nor workflow to be comfortable in that role. I am happy enough to open issues/PRs for now as needed. Thanks for the offer. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants