Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add projects #3

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open

Add projects #3

wants to merge 22 commits into from

Conversation

kinggoesgaming
Copy link
Member

@kinggoesgaming kinggoesgaming commented May 22, 2017 •
edited by pie-flavor
Loading

Contradictory to previous flat file structure in types.rs the whole thing is now split over several files/ modules for organisation.

TODO:

  • Write Query implementations for Project and Version
  • Provide getters and setters where needed.
  • Provide getting Version bytes for downloading.
  • Provide documentation.
  • Write relevant tests.
  • Remove relevant types from types.rs.

closes #2

@kinggoesgaming
begin work on Projects
d185581 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
woops
203eba6 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
first steps on the projects complete
8ae9f57 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming kinggoesgaming self-assigned this May 22, 2017
@kinggoesgaming kinggoesgaming requested a review from pie-flavor May 22, 2017 19:59
@kinggoesgaming
lets try fixing cargo registry
58bd54d 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
fix the webpki error + remove the derive_builder errors
dcb8268 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
its working locally...
b854684 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
ok this is getting annoying now
ea79e1e 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
ok finally working, hyper-rustls was outdated
22dcd5e 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
no need for these anymore
83defea 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
provide getters and do some housekeeping
85c5213 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
fix module path comments
98b072a 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
query (re)fixed
082af3d 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
rewrite some structs to remove the &str
a9b2849 
, remove Query, replace with Request, provide a ProjectsQuery

Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
ProjectsQuery -> ProjectsRequest
90a531f 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
formatting fixes
bcdd095 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
add request functions for projects
6087093 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
revert revert revert
29cd95b 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
eliminate unnecessary module
8d0dfc2 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
oops i forgot to delete the file
3a1e1c9 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
introduce prelude
0acb770 
Signed-off-by: Hunar Roop Kahlon <[email protected]>
@kinggoesgaming
Copy link
Member Author

kinggoesgaming commented May 28, 2017 •
edited
Loading

@pie-flavor can you start reviewing this... i want to make sure that i dont have to do major overhaul after this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pie-flavor pie-flavor Awaiting requested review from pie-flavor

Assignees

@kinggoesgaming kinggoesgaming

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kinggoesgaming