Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce error and signal types #2672

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Nov 9, 2024

Improve readability and avoid typing errors.

Related #2273

@MattHag MattHag requested a review from pfps November 9, 2024 23:51
@MattHag MattHag changed the title Introduce error types for error dialog Introduce error and signal types Nov 10, 2024
@MattHag MattHag force-pushed the error_dialog branch 2 times, most recently from 27f4c00 to f741505 Compare November 15, 2024 23:05
@pfps
Copy link
Collaborator

pfps commented Jan 1, 2025

There are conflicts to be resolved.

@pfps
Copy link
Collaborator

pfps commented Jan 1, 2025

Most or all of the remaining PRs have conflicts or have caused problems. Let me know if there are ones that are candidates to be merged.

@MattHag MattHag force-pushed the error_dialog branch 4 times, most recently from ca0c236 to 09b3b94 Compare January 1, 2025 19:04
@MattHag
Copy link
Collaborator Author

MattHag commented Jan 1, 2025

Fixed

Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pfps pfps merged commit e9a58fb into pwr-Solaar:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants