Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BoltReceiver, Ex100Receiver __init__ #2661

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

piec
Copy link
Contributor

@piec piec commented Nov 5, 2024

Fixes #2674

Fix errors like during init:

Exception ignored in: <function Receiver.__del__ at 0x7fe4742a37e0>
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/logitech_receiver/receiver.py", line 146, in __del__
    self.close()
  File "/usr/lib/python3.12/site-packages/logitech_receiver/receiver.py", line 138, in close
    handle, self.handle = self.handle, None
                          ^^^^^^^^^^^
AttributeError: 'BoltReceiver' object has no attribute 'handle'
2024-11-06 09:55:24,035,035    ERROR [MainThread] logitech_receiver.receiver: open DeviceInfo(path='/dev/hidraw7', bus_id=3, vendor_id='046D', product_id='C548', interface=2, driver='hid-generic', manufacturer=None, product=None, serial='', release=None, isDevice=None, hidpp_short=True, hidpp_long=True)
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/logitech_receiver/receiver.py", line 536, in create_receiver
    return rclass(
           ^^^^^^^
TypeError: BoltReceiver.__init__() takes from 6 to 7 positional arguments but 8 were given

@MattHag
Copy link
Collaborator

MattHag commented Nov 6, 2024

Looks good, I missed pushing these in a refactoring, I think. Thanks.

Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@pfps pfps merged commit 8b0904e into pwr-Solaar:master Nov 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression from 1.1.13: BoltReceiver is broken
3 participants