Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Set locale via LC_ALL env variable #2509

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented May 30, 2024

Solaar relies on the LC_ALL variable for language overrides on macOS. Define the variable to change the language.

Usage example for German on macOS:
LC_ALL=de_DE.UTF-8 solaar

Related #2507

Solaar relies on the LC_ALL variable for language overrides. Define
the variable to change the language.

Usage example for German:
LC_ALL=de_DE.UTF-8 solaar

Related pwr-Solaar#2507
@pfps
Copy link
Collaborator

pfps commented Jun 1, 2024

Is 'LC_ALL=de_DE.UTF-8 solaar' the recommended way to change locale or is the recommended variable LANGUAGE?

@MattHag
Copy link
Collaborator Author

MattHag commented Jun 1, 2024

It's the only one that has an effect on macOS. On Linux it seems to be handled differently.

Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pfps pfps merged commit 244d0ee into pwr-Solaar:master Jun 1, 2024
5 checks passed
@MattHag MattHag deleted the localization branch June 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants