Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for end-of-life Python 3.7 #2479

Merged
merged 2 commits into from
May 11, 2024
Merged

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented May 10, 2024

Fixes #2478

@pfps
Copy link
Collaborator

pfps commented May 10, 2024

Although 3.7 may be EOL is there a non-EOL Linux distribution that uses it? If so, it is too soon to require 3.8.

@MattHag
Copy link
Collaborator Author

MattHag commented May 10, 2024

I don't know, and I wouldn't care too much, as this is just an issue of installation. Solaar should be installed with its own dependencies and not rely on the system Python version. The package maintainers wrapping Solaar are responsible to set up an appropriate Python version or drop support for too old releases.

I'd introduce an official package built by GitHub CI and published on every release. Flatpak with 39 supported distros sounds promising to me and is certainly one of the most prominent ones. It should handle the autorun configuration, which the APT package of Solaar already does, but the manual installation via source does not do automatically. An independent packages built with a release would allow immediate updates for flatpak users and could avoid the need for unofficial packages, we don't know what's inside.

@pfps
Copy link
Collaborator

pfps commented May 10, 2024

Distribution via flatpak was tried by someone and there were problems, I think because of the udev rule.

@pfps
Copy link
Collaborator

pfps commented May 10, 2024

Looks reasonable for after 1.1.13 goes out.

Copy link
Collaborator

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pfps pfps merged commit b321167 into pwr-Solaar:master May 11, 2024
3 checks passed
@MattHag MattHag deleted the drop_eol_py37 branch May 16, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for EOL Python 3.7
2 participants