Fix app name casing in UI #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfps
reviewed
Mar 4, 2024
lib/solaar/__init__.py
Outdated
| @@ -19,6 +19,7 @@ | |||
| import sys as _sys | |||
|
|
|||
| NAME = "solaar" | |||
| DISPLAY_NAME = "Solaar" | |||
There was a problem hiding this comment.
The display name should be derived from the name, not a separate constant. Even better, use only Solaar and then .lower() where a lower-case name is needed. There are already several places where .lower() is used.
|
@pfps made the changes, NAME is now |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DISPLAY_NAME which is just
solaarwith first letter capitalized, as should app names be.Didn't add this to translation stuff since I see that
Solaaris kept as is in all translations, so won't make a difference.