Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header of readme #2333

Closed
wants to merge 2 commits into from
Closed

Update header of readme #2333

wants to merge 2 commits into from

Conversation

MattHag
Copy link
Collaborator

@MattHag MattHag commented Feb 25, 2024

Related #2328

Add logo, description, quick links screenshots and quick links and GitHub badges.

pwr-Solaar#2328
@MattHag MattHag changed the title Readme-2328 Update header of readme Feb 25, 2024
@pfps
Copy link
Collaborator

pfps commented Feb 26, 2024

This PR changes docs/index.md. It would be better to have a separate README.md, which would be shorter, and reference index.md. As well, HTML should be kept to the very minimum as this is a markdown document.

@pfps
Copy link
Collaborator

pfps commented Feb 26, 2024

See #2338
I copied your changes and made a lot of modifications. There is a problem with getting two images on the same line. Maybe using more HTML is the solution.

@MattHag
Copy link
Collaborator Author

MattHag commented Feb 26, 2024

See #2338 I copied your changes and made a lot of modifications. There is a problem with getting two images on the same line. Maybe using more HTML is the solution.

They need a wrapping element it seems.

@pfps
Copy link
Collaborator

pfps commented Feb 26, 2024

Yeah #2339 appears to have fixed things.

@MattHag MattHag closed this Feb 28, 2024
@MattHag MattHag deleted the docs-2328 branch March 8, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants