Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the <developer/> tag in the metainfo #2296

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

proletarius101
Copy link
Contributor

@pfps
Copy link
Collaborator

pfps commented Feb 17, 2024

Daniel hasn't been involved with Solaar in quite some time. What is supposed to go in this field?

@proletarius101
Copy link
Contributor Author

Daniel hasn't been involved with Solaar in quite some time. What is supposed to go in this field?

I just saw that his name is in many places of this repository as the author of this project.

This field is supposed to be the name of developers or project responsible for development of the project. Values might be for example "The GNOME Foundation" or "The KDE Community".

Can you propose such a name if the current one is inappropriate?

@pfps
Copy link
Collaborator

pfps commented Feb 17, 2024

Me, at this point. I'll make a suggested change to the PR and also a change to the project location.

@pfps
Copy link
Collaborator

pfps commented Feb 17, 2024

OK, this can go in now, before 1.1.11.

pfps
pfps previously requested changes Feb 17, 2024
share/solaar/io.github.pwr_solaar.solaar.metainfo.xml Outdated Show resolved Hide resolved
@pfps pfps dismissed their stale review February 17, 2024 18:14

outdated

@pfps pfps merged commit 3dcc1eb into pwr-Solaar:master Feb 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants