-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: Simplify imports and initialization #2257
Conversation
I get errors in this PR
|
@MattHag See previous comment about errors. |
I see my mistake, used the wrong capitalization for some replacements. |
lib/solaar/gtk.py
Outdated
@@ -117,7 +114,7 @@ def _parse_arguments(): | |||
logging.getLogger('').addHandler(stream_handler) | |||
|
|||
if not args.action: | |||
if _log.isEnabledFor(logging.INFO): | |||
if logger.isEnabledFor(logging.INFO): | |||
logging.info('version %s, language %s (%s)', __version__, _i18n.language, _i18n.encoding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be logger.info as well?
@MattHag Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
Fixes #2254