-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for extended adjustable dpi #2237
Conversation
7dfbd90
to
ac48f04
Compare
ee4464a
to
beca569
Compare
2888400
to
f9a7012
Compare
Yes indeed. |
Yes indeed. Should be fixed now |
40e0b22
to
17fd1f1
Compare
f19b891
to
597b905
Compare
The mouse is not shown at all, something broke :( |
solar dpi change.log |
Does your mouse have both X and Y dpi? Solaar only gets and sets the X dpi and I'm not sure what this does for a mouse with both. The Pro X 2 appears to have lots of possible dpi values. Does this slow Solaar down appreciably? What happens if you try to change the DPI with an active profile? |
What happens with the exception? Solaar should just mark the setting as in an error state and proceed. What is happening is that for some devices an active onboard profile prevents changes to the DPI. Try turning off onboard profiles and see what happens. |
now a different error with onboard profiles disabled |
My guess is that your mouse supports different resolutions for X and Y directions and that 0 is not allowable for the Y direction. There are several ways to support this. I'll try the simplest - one that assumes that all valid X resolutions are also valid Y resolutions. |
The current version of the PR makes some allowances for y direction DPI but assumes that it can be set the same as the x direction DPI. I had thought that it would be a lot of work to separate them, but it may not be too difficult in the end. But please try out this version and post the result of |
25b3304
to
8330950
Compare
@MattHag I removed the pip-installed Solaar on my machine and now I'm experiencing strange effects with pytest.
generates a reasonable coverage report, but
produces the warning Any ideas on what is going on? |
No, I don't know. But the coverage on GitHub is mostly lower than local. |
dcfd263
to
4b48bd6
Compare
Getting the same error as described by CuteSC2 even after these commits |
See the bug issue for this change. |
Regarding the coverage, that could be caused by a seg fault, which I get at least locally from one test. |
Fixes #2207