-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add snacks picker support for issues, prs, and notifications #858
Conversation
- Updated README.md to include 'folke/snacks.nvim' as an option - Modified config.lua to add 'snacks' to OctoPickers alias and validate_pickers - Added new file provider.lua for snacks picker with not implemented methods
Cool. I think that it would be good to approach this in multiple PRs for the sake of the reviewers |
At the moment I am just working in separate commits to make the review easier. I am planning to just do issues/prs/notifications then the rest of the changes can go in separate PRs |
I think this is probably ready for an initial review now as a starting point and then we can iterate in future PRs |
That'd be a great start. Feel free to make some sub-issues on the current issue to let others know the status |
I think im done here with first iteration. But I think I'm happy with this as a first pass id like to work out how to get the |
Will take another look
Not exactly sure what you mean. You can use the local gh = require "octo.gh"
local query = [[
query {
viewer {
login
}
}
]]
local cb = function(output)
vim.notify("Greetings " .. output)
end
gh.api.graphql {
query = query,
jq = ".data.viewer.login",
opts = { cb = cb }
} Feel free to raise another issue and we can discuss ideas separate from this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Let's iterate!
## Description A [PR](pwntester/octo.nvim#858) has landed in `octo.nvim` that adds initial support for `snacks.picker`. Enable it in `octo.nvim` Extra if user uses `snacks.picker`. I also changed the checks to use `has_extra`. This was needed for `snacks.picker`, since `has("snacks.nvim")` doesn't ensure that user also has `snacks.picker` enabled. For the others I just changed it for conformity, but if you think there might be something wrong about that (that I'm unable to think of), please feel free to change them back. <!-- Describe the big picture of your changes to communicate to the maintainers why we should accept this pull request. --> ## Related Issue(s) None <!-- If this PR fixes any issues, please link to the issue here. - Fixes #<issue_number> --> ## Screenshots <!-- Add screenshots of the changes if applicable. --> ## Checklist - [x] I've read the [CONTRIBUTING](https://github.com/LazyVim/LazyVim/blob/main/CONTRIBUTING.md) guidelines.
## Description A [PR](pwntester/octo.nvim#858) has landed in `octo.nvim` that adds initial support for `snacks.picker`. Enable it in `octo.nvim` Extra if user uses `snacks.picker`. I also changed the checks to use `has_extra`. This was needed for `snacks.picker`, since `has("snacks.nvim")` doesn't ensure that user also has `snacks.picker` enabled. For the others I just changed it for conformity, but if you think there might be something wrong about that (that I'm unable to think of), please feel free to change them back. <!-- Describe the big picture of your changes to communicate to the maintainers why we should accept this pull request. --> ## Related Issue(s) None <!-- If this PR fixes any issues, please link to the issue here. - Fixes #<issue_number> --> ## Screenshots <!-- Add screenshots of the changes if applicable. --> ## Checklist - [x] I've read the [CONTRIBUTING](https://github.com/LazyVim/LazyVim/blob/main/CONTRIBUTING.md) guidelines.
WIP adding snacks picker support
Closes #809
Just a draft for now but will add more support
Issues:

PRs:
