fix: fix 'edit' actions documented arguments #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make it behave the other way though? That is closer to the gh cli. Thoughts? |
|
Oh! I don't feel strongly, if you'd like to see this, easy enough to make it happen :). I don't mind at all to actually flip the code, and leave the docs the way they are today. |
|
I think itd be good to be consistent with the cli Thanks for making the change |
At some point the documentation for editing and issue and a pr drafted
from the code.
Update `get_repo_number_from_varargs` to reflect the documentation.
The documentation says `Octo pr [number] {repo}`
However, the code expected `Octo pr {repo} [number]`.
Fix this confusion by conforming to the documentation.
Signed-off-by: ldelossa <[email protected]>
ldelossa
force-pushed
the
ldelossa/fix-docs
branch
from
ea68ddc to
3f6d22a
Compare
|
@wd60622 handled your requested change. |
wd60622
approved these changes
Feb 2, 2025
This was referenced Feb 3, 2025
benelan
added a commit
to benelan/octo.nvim
that referenced
this pull request
Feb 3, 2025
This reverts commit 781545b. Resolves pwntester#841
TheLeoP
added a commit
to TheLeoP/octo.nvim
that referenced
this pull request
Feb 3, 2025
This is an alternative to pwntester#842
2 tasks
TheLeoP
added a commit
to TheLeoP/octo.nvim
that referenced
this pull request
Feb 3, 2025
This is an alternative to pwntester#842
wd60622
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs only change.
Seems like arguments for pr.edit and pr.issue were backwards.
At some point the documentation for editing and issue and a pr drafted
from the code.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist