Fix fetch timeout for newly added files #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelossa
approved these changes
Jan 28, 2025
GuillaumeLagrange
approved these changes
Jan 29, 2025
GuillaumeLagrange
force-pushed
the
fix-fetch-timeout
branch
from
4d55d8c to
3ab7858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
When one side of the file is empty
return #self.left_lines > 0 and #self.right_lines > 0will always be false. Thusis_ready_to_renderwill never be true.Does this pull request fix one issue?
Fixes #817
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist