fix: make comment ranges work #807
Conversation
|
Were there any issues for this? |
|
Only relevant issue is: #303 But there seems to be a lot of refactoring since then. Possible it broke or most people are using keymaps to create multiline comments? I'm not sure. I'd want the command to work for multi-line comments, as I already have far too many keymaps and just typing things out are becoming an easier approach. |
Previous to this comment highlighting several lines and running the command "Octo comment add" would never result in a multi-line comment. This is seemingly because as soon as you enter the command line with ':' Neovim is switched back into normal mode and the "v" and "." attributes to `vim.fn.line` no longer register for the line range. Instead, we can use the explicit start and end marks for a selected range to capture the currently selected range despite being in normal mode at time of command run. Signed-off-by: ldelossa <[email protected]>
ldelossa
force-pushed
the
ldelossa/make-comment-ranges-work
branch
from
559e06e to
f369961
Compare
|
Awesome. Let me take a look tomorrow |
|
Closes #587 |
| line_number_start = vim.fn.line "v" | ||
| line_number_end = vim.fn.line "." | ||
| line_number_start = vim.fn.line "'<" | ||
| line_number_end = vim.fn.line "'>" |
There was a problem hiding this comment.
When you say "non range selections" what do you mean? Can you give me steps to reproduce and ill take a look
There was a problem hiding this comment.
I meant in the normal mode. When I add comment without any visual selection, the comment buffer can still pop up. But when I save the comment, it will fail with an error "failed to create thread".
I dug into this issue and it turned out that the bug is because the line numbers are 0.
There was a problem hiding this comment.
And is this with a keybind or you type the add comment command?
There was a problem hiding this comment.
Yup I see. Thanks for info. I think youre onto it with maybe using "visual" argument in every scenario.
There was a problem hiding this comment.
Okay I am recalling why I have not ran into this.
Canonically, a command figures out if a selection is being provided to it based on the arguments the command is called with.
For instance when you highlight a few lines and you enter the command line with ":" there is a reason you see this:
Its because Neovim doesn't really provide a way for you to access "the previous mode before you entered the command line". Instead, if you entered with a a line range you get the range as arguments to the command.
The issue I see is that Octo does not plumb user command arguments down into command handlers.
I can see how easily we can do this, it would be the "right" for this, and Octo can stop trying to retroactively understand whether visual lines are highlighted or not.
There was a problem hiding this comment.
Opened a PR with a proposed fix for this: #825
Previous to this comment highlighting several lines and running the command "Octo comment add" would never result in a multi-line comment.
This is seemingly because as soon as you enter the command line with ':' Neovim is switched back into normal mode and the "v" and "." attributes to
vim.fn.lineno longer register for the line range.Instead, we can use the explicit start and end marks for a selected range to capture the currently selected range despite being in normal mode at time of command run.
It is now possible to highlight several lines in a review and then call "Octo comment add" to create a multi-line comment.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews
Checklist