Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing title renaming event #707

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Conversation

wd60622
Copy link
Collaborator

@wd60622 wd60622 commented Dec 9, 2024

Describe what this PR does / why we need it

Title renaming events are now in the issues and pr buffers

Does this pull request fix one issue?

Related to #680

Describe how you did it

Three steps:

  • Change to graphql query to get the title renaming events
  • Add some parsing to render
  • Add writer

Describe how to verify it

Can view in prs like this one or like #635

Or in Issues like #680

Special notes for reviews

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

@wd60622
Copy link
Collaborator Author

wd60622 commented Dec 9, 2024

Note

I changed to have a strikethrough and same "changed the title" which is used in the web interface.

renamed event in PR timeline (from user other than self)
pr-rename
renamed event in issue timeline
issue-rename

@wd60622 wd60622 changed the title Add event for title renaming Add missing title renaming event Dec 9, 2024
@wd60622
Copy link
Collaborator Author

wd60622 commented Dec 11, 2024

This is how it looks now! More like GitHub UI

updated-change-title

@wd60622 wd60622 merged commit b9c727f into pwntester:master Dec 14, 2024
2 checks passed
@wd60622 wd60622 deleted the add-rename-events branch December 14, 2024 01:29
@wd60622 wd60622 mentioned this pull request Dec 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant