Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comment statuscolumn & foldtext #555

Merged
merged 9 commits into from
Jun 8, 2024

Conversation

folke
Copy link
Contributor

@folke folke commented Jun 7, 2024

Describe what this PR does / why we need it

This PR fixes both issues/features as described in #80:

  • use statuscolumn on Neovim >= 0.9 for rendering comment signs, so that they render correctly when wrapping
  • use foldtext on Neovim >= 0.10 for better rendering of folded comments/threads/...

Does this pull request fix one issue?

Fixes #80

Describe how you did it

I implemented both a statuscolumn and foldtext.
See the two different commits.

Describe how to verify it

In Neovim 0.10, check the features described

Special notes for reviews

In the screenshot you can see comment markers from a wrapped comment.
And what a folded thread looks like (lighter background)

Edit: I seem to have included the code from my other PR as well :)

image

@pwntester
Copy link
Owner

pwntester commented Jun 8, 2024

Thats awesome, thanks! I had some basic statuscolumn recommendations in the README but I like the idea of building it in. Will review ASAP.

Alvaro Muñoz added 4 commits June 8, 2024 22:48
Let the use_statuscolumn and use_signcolumn decide where to render the comment marks.
@pwntester pwntester merged commit 6963068 into pwntester:master Jun 8, 2024
2 checks passed
@pwntester
Copy link
Owner

Thanks again @folke!

@folke
Copy link
Contributor Author

folke commented Jun 8, 2024

Thanks for merging!

One thing I just thought about is that signs.place is also used when not part of signs.place_signs in the file-entry module.

The new statusline impl, won't show those signs right now, but I can add them as well.

I'm still pretty new to octo, so where can I see that file-entry being used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Neovim to get signs printed on wrapped lines
2 participants