Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py3.11 to test matrix #38

Merged
merged 6 commits into from
Jan 5, 2023
Merged

Add py3.11 to test matrix #38

merged 6 commits into from
Jan 5, 2023

Conversation

kandersolar
Copy link
Member

No description provided.

@kandersolar kandersolar added this to the v0.2.4 milestone Dec 19, 2022
@kandersolar kandersolar marked this pull request as ready for review December 19, 2022 17:22
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also have the tests run on a cron schedule, e.g., once a week or month? I imagine that we won't have many PRs in the future, and thus we would detect issues like #39 with a significant delay.

@kandersolar
Copy link
Member Author

Would it make sense to also have the tests run on a cron schedule, e.g., once a week or month?

I think running them once a week or so is a good idea. What's a good way to make test failures noisy enough to make us notice? I think it's possible to have a CI job open github issues. Maybe just emailing us is enough.

@AdamRJensen
Copy link
Member

AdamRJensen commented Jan 4, 2023

I think running them once a week or so is a good idea. What's a good way to make test failures noisy enough to make us notice? I think it's possible to have a CI job open github issues. Maybe just emailing us is enough.

How about adding a cron schedule to the GitHub Actions? The below example would run at 00:00 every Sunday.

on:
  schedule:
    - cron: '0 0 * * 0'

In case of failure, wouldn't that email us? I think that should be sufficient - no need for a complicated workflow that creates an issue.

@kandersolar
Copy link
Member Author

In case of failure, wouldn't that email us?

I don't receive email notifications for CI failures in any other job. Probably it's possible to get them somehow. I would only want to enable them if they can be enabled per repo or even per workflow though :)

@AdamRJensen
Copy link
Member

AdamRJensen commented Jan 5, 2023

I don't receive email notifications for CI failures in any other job. Probably it's possible to get them somehow. I would only want to enable them if they can be enabled per repo or even per workflow though :)

Good point - let's tackle this in another issue/PR since it's not time-sensitive and does not require a new release.

@AdamRJensen AdamRJensen merged commit 1302a96 into main Jan 5, 2023
@AdamRJensen
Copy link
Member

Thanks, @kanderso-nrel - you're a champ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants