Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consider issue comments in the attention set #94

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

pvcnt
Copy link
Owner

@pvcnt pvcnt commented Aug 27, 2024

This is a large rework of how pull requests are searched and fetched from GitHub. It now happens in two steps. Searching returns only node IDs. Pull requests are then fetched from this node ID.

This allows to retrieve much more information at once when fetching the pull request, while still keeping the request cost reasonable (cost=1), to avoid hitting rate limiting.

As a consequence, we now fetch issue comments, reviews and review comments, and consider all of them when computing the attention set. We are also able to ignore resolved discussions.

Closes #60

This is a large rework of how pull requests are searched and fetched from GitHub.
It now happens in two steps. Searching returns only node IDs. Pull requests are
then fetched from this node ID.

This allows to retrieve much more information at once when fetching the pull request,
while still keeping the request cost reasonable (cost=1), to avoid hitting rate limiting.

As a consequence, we now fetch issue comments, reviews and review comments, and consider
all of them when computing the attention set.

Closes #60
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 65.13761% with 38 lines in your changes missing coverage. Please review.

Files Patch % Lines
packages/github/src/client.ts 52.94% 30 Missing and 2 partials ⚠️
apps/webapp/src/worker/instance.ts 78.57% 5 Missing and 1 partial ⚠️

@pvcnt pvcnt merged commit 024a6eb into main Aug 27, 2024
1 check passed
@pvcnt pvcnt deleted the issue-comments branch August 27, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use request throttling
1 participant