Replace "" with string.Empty. Some logic work in AniDB HTTP saving an…

…d parsing
purposelycryptic · Sep 21, 2017 · 1304743 · 1304743
1 parent 02d1d71
commit 1304743
Show file tree

Hide file tree

Showing 91 changed files with 562 additions and 637 deletions.
diff --git a/Shoko.Server/API/APIHelper.cs b/Shoko.Server/API/APIHelper.cs
@@ -237,7 +237,7 @@ private static string ProperURL(NancyContext ctx, int? port, string path, bool s
             }
             else
             {
-                return "";
+                return string.Empty;
             }
         }
     }

diff --git a/Shoko.Server/API/v1/Implementations/ShokoServiceImplementation/ShokoServiceImplementation.cs b/Shoko.Server/API/v1/Implementations/ShokoServiceImplementation/ShokoServiceImplementation.cs
@@ -46,7 +46,7 @@ public CL_Response<CL_BookmarkedAnime> SaveBookmarkedAnime(CL_BookmarkedAnime co
         {
             CL_Response<CL_BookmarkedAnime> contractRet = new CL_Response<CL_BookmarkedAnime>
             {
-                ErrorMessage = ""
+                ErrorMessage = string.Empty
             };
             try
             {
@@ -104,7 +104,7 @@ public string DeleteBookmarkedAnime(int bookmarkedAnimeID)
 
                 RepoFactory.BookmarkedAnime.Delete(bookmarkedAnimeID);
 
-                return "";
+                return string.Empty;
             }
             catch (Exception ex)
             {
@@ -369,7 +369,7 @@ public List<string> DirectoriesFromImportFolderPath(int cloudaccountid, string p
                     }
                     if (path.Equals("null"))
                     {
-                        path = "";
+                        path = string.Empty;
                     }
                     dirr = n.Resolve(path);
                     if (dirr == null || !dirr.IsOk || dirr.Result is IFile)
@@ -408,7 +408,7 @@ public CL_Response SaveServerSettings(CL_ServerSettings contractIn)
         {
             CL_Response contract = new CL_Response
             {
-                ErrorMessage = ""
+                ErrorMessage = string.Empty
             };
             try
             {
@@ -741,7 +741,7 @@ public void ClearGeneralQueue()
 
         public string TestAniDBConnection()
         {
-            string log = "";
+            string log = string.Empty;
             try
             {
                 log += "Disposing..." + Environment.NewLine;
@@ -890,7 +890,7 @@ public string EnableDisableImage(bool enabled, int imageID, int imageType)
                         break;
                 }
 
-                return "";
+                return string.Empty;
             }
             catch (Exception ex)
             {
@@ -952,7 +952,7 @@ public string SetDefaultImage(bool isDefault, int animeID, int imageID, int imag
                 SVR_AnimeSeries series = RepoFactory.AnimeSeries.GetByAnimeID(animeID);
                 RepoFactory.AnimeSeries.Save(series, false);
 
-                return "";
+                return string.Empty;
             }
             catch (Exception ex)
             {
@@ -1031,7 +1031,7 @@ public string UpdateCalendarData()
             {
                 logger.Error(ex, ex.ToString());
             }
-            return "";
+            return string.Empty;
         }
 
         /*public List<Contract_AniDBAnime> GetMiniCalendar(int numberOfDays)
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 else
                 {
-                    return "";
+                    return string.Empty;
                 }
             }
         }
@@ Expand Down @@