Change default chmod behaviour, update xinetd dependency. #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until after v3.0.7, rsync's chmod directives completely ignored octal chmods, only paying attention to "Du+rwx"-style specifiers. When upgrading from rsync v3.0.7 to v3.0.10, I hit an issue wherein rsynced directories became inaccessible because the 644 permissions are applied to all files and directories, and directories lacked executable bits. Rather than change this chmod to a comprehensive "Du+rwx,go+rx,Fu+rwx,go+r", I think it makes sense to disable the chmod by default and allow users to configure their own chmods per-module and otherwise maintain the original modes set on files.
This PR also updates the fixtures to use the now-puppetlabs-maintained xinetd repository and updates test facts accordingly.