-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't insert the address
option if not specified.
#144
base: main
Are you sure you want to change the base?
Conversation
rsync::server is a classthat may have no external impact to Forge modules. This module is declared in 30 of 578 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the change. Please see my inline comments.
Also, it seems you have not yet signed CLA, which is required to approve this change later.
3b763a6
to
d53eba8
Compare
Should be fixed up now. |
Sorry for the delay in merge. Had some trouble with my account permission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing my vote because rebase is needed
Rebased |
The previous default made rsyncd an IPv4 only service by default.
This change instead uses the rsyncd default when unset. This
easily allows dual stack services to provide rsyncd.