-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-11135) puppet_agent : Add task support for Rocky Linux 8.4 Green Obsidian #571
Conversation
1159be1
to
6d8f2c6
Compare
Thanks for your contribution @Guillaume001, If you've signed the CLA, the check could be failing because your commit is associated to 2 email addresses (and one of the addresses is not linked to your GitHub profile). Also, your commit message links to the wrong ticket (MODULES-11133 instead of MODULES-11135), it would be good to fix that. |
241d0ae
to
013384d
Compare
Hello Gabriel Nagy, Thank you for your feedback. |
013384d
to
eedfa3c
Compare
2652c21
to
f2856f0
Compare
f2856f0
to
de05629
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍, but I'll let @puppetlabs/bolt have the final say since they own the task part of the module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tasks looks good on our end and successfully installs on Rocky.
When running the puppet_agent::install task on a Rocky Linux target, the following message appears :
20:24:31 +0000 INFO: Version parameter not defined and no agent detected. Assuming latest.
20:24:31 +0000 INFO: Downloading Puppet latest for Rocky...
20:24:31 +0000 CRIT: Sorry Rocky is not supported yet!