Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-11135) puppet_agent : Add task support for Rocky Linux 8.4 Green Obsidian #571

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

Guillaume001
Copy link

When running the puppet_agent::install task on a Rocky Linux target, the following message appears :

20:24:31 +0000 INFO: Version parameter not defined and no agent detected. Assuming latest.
20:24:31 +0000 INFO: Downloading Puppet latest for Rocky...
20:24:31 +0000 CRIT: Sorry Rocky is not supported yet!

@Guillaume001 Guillaume001 requested a review from a team as a code owner July 14, 2021 09:07
@Guillaume001 Guillaume001 requested a review from a team July 14, 2021 09:07
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2021

CLA assistant check
All committers have signed the CLA.

@GabrielNagy
Copy link
Contributor

GabrielNagy commented Jul 14, 2021

Thanks for your contribution @Guillaume001,

If you've signed the CLA, the check could be failing because your commit is associated to 2 email addresses (and one of the addresses is not linked to your GitHub profile).

Also, your commit message links to the wrong ticket (MODULES-11133 instead of MODULES-11135), it would be good to fix that.

@Guillaume001
Copy link
Author

Guillaume001 commented Jul 14, 2021

Hello Gabriel Nagy,

Thank you for your feedback.
I have just signed the CLA. I have just corrected the description of the commits with the correct ticket name.

@GabrielNagy GabrielNagy changed the title (Modules 11135) puppet_agent : Add support for Rocky Linux 8.4 Green Obsidian (MODULES-11135) puppet_agent : Add task support for Rocky Linux 8.4 Green Obsidian Jul 14, 2021
@Guillaume001 Guillaume001 force-pushed the MODULES-11135 branch 3 times, most recently from 2652c21 to f2856f0 Compare July 14, 2021 16:51
Copy link
Contributor

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍, but I'll let @puppetlabs/bolt have the final say since they own the task part of the module.

Copy link
Contributor

@beechtom beechtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tasks looks good on our end and successfully installs on Rocky.

@beechtom beechtom merged commit 3538bae into puppetlabs:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants