(FACT-3205) Ignore ENOENT when cleaning up temporary test files #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facter tests sometimes fail on JRuby with the following, even when using
the same seed:
$ bundle exec rspec --order random:22464 spec_integration
...
Errno::ENOENT:
No such file or directory - /tmp/external_facts20240617-2780089-h18bte/XFZQDAMC_data.yaml
# ./spec_integration/facter_spec.rb:13:in `write_to_file'
# ./spec_integration/facter_spec.rb:752:in `block in <main>'
Since ENOENT means the entry doesn't exist, ignore it like puppet does[1].
However, we don't want to use `rm_rf` because that will ignore all
StandardErrors, not just ENOENT[2].
[1] https://github.com/puppetlabs/puppet/blob/8.6.0/spec/lib/puppet_spec/files.rb#L11-L15
[2] https://bugs.ruby-lang.org/issues/18784
joshcooper
force-pushed
the
write_to_file
branch
from
6efe080 to
69030d1
Compare
joshcooper
changed the title
|
For the commit, 69030d1, could we just include the removal of |
joshcooper
force-pushed
the
write_to_file
branch
from
69030d1 to
73fa004
Compare
cthorn42
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facter tests sometimes fail on JRuby with the following, even when using
the same seed:
Since ENOENT means the entry doesn't exist, ignore it like puppet does[1].
However, we don't want to use
rm_rfbecause that will ignore allStandardErrors, not just ENOENT[2].
[1] https://github.com/puppetlabs/puppet/blob/8.6.0/spec/lib/puppet_spec/files.rb#L11-L15
[2] https://bugs.ruby-lang.org/issues/18784