Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Debug broken github notify #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

WIP: Debug broken github notify #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions environments/development.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,17 @@
"worker": "autumn",
"image": "ocaml/opam:debian-11-ocaml-4.13",
"notify_github": true
},
{
"name": "punchagan/current-bench",
"worker": "autumn",
"image": "ocaml/opam:debian-11-ocaml-4.13",
"notify_github": true
},
{
"name": "punchagan/dune",
"worker": "autumn",
"notify_github": true
}
],
"api_tokens": [
Expand Down
2 changes: 1 addition & 1 deletion local-repos/test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ define BENCH_DATA_B1_T1_A
},
{
"name": "grammarFunctor/typing",
"value": 0.28,
"value": 0.2,
"units": "secs",
"trend": "lower-is-better"
},
Expand Down
1 change: 1 addition & 0 deletions pipeline/lib/metric.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ let notify_metric_changes ~conninfo ~repository ~worker ~docker_image ~config
match (pull_number, should_notify) with
| Some pull_number, Some _ ->
let job_id = Current.map (fun _ -> job_id_) output in
Logs.info (fun log -> log "Notifications enabled for %s ..." repo_id);
notify ~conninfo ~repository ~worker ~docker_image ~pull_number job_id
| None, _ -> Current.return "Not a pull request"
| _, None ->
Expand Down