Multi branch, yet another PR with different base #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For repositories like ocaml/ocaml, we would like the benchmarks to be maintained potentially by a bigger/different set of users, than the ocaml/ocaml maintainers. This commit adds support for an additional configuration variable that lets us clone an additional repository and run benchmarks from within it. NOTE: No new benchmark runs would be triggered by any changes to the benchmarks repository, with this setup.
punchagan
force-pushed
the
multi-branch-old
branch
from
b75a3e0 to
16aa6ea
Compare
punchagan
force-pushed
the
multi-branch
branch
2 times, most recently
from
3bc0b0f to
ca54750
Compare
punchagan
force-pushed
the
multi-branch
branch
2 times, most recently
from
84a9a20 to
e78519b
Compare
ff71364 modified the reload.sh script to use `dune exec --watch` instead of `dune build --watch`. The github-app.sh script was run in the foreground, with the `dune build` running in the background. The change to `dune exec` script needs to make the `exec` command to be run in the foreground, but missed out on making the gitub-app.sh invocation happen in the background. This commit fixes the problem of `dune exec` not running.
punchagan
force-pushed
the
multi-branch-old
branch
from
16aa6ea to
bfdaabe
Compare
Previously, we filtered out the branches which don't have the required label, before starting the benchmarking run. But, this meant that the metadata for the branch is already saved to the DB and displayed in the UI. This commit changes the filtering to be run before the metadata for the benchmark run is setup.
This would be useful for benchmarking more than one long running branches of a repository, for instance, the `5.0` and `trunk` branches of ocaml/ocaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.