Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes-aws-java and container-aws-java templates #880

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

justinvp
Copy link
Member

@justinvp justinvp commented Feb 8, 2025

Fixes #876

This change adds kubernetes-aws-java and container-aws-java templates.

@justinvp
Copy link
Member Author

justinvp commented Feb 8, 2025

I'm running into pulumi/pulumi-awsx#820 when deploying a project created from the container-aws-java template.

pulumi new https://github.com/pulumi/templates/tree/justin/java-workshop/container-aws-java
pulumi up

The deployment runs, but fails creating the service with:

error: awsx:ecs:FargateService resource 'service' has a problem: Exactly one of [container] or [containers] must be provided

@justinvp
Copy link
Member Author

justinvp commented Feb 8, 2025

Also running into an issue deploying kubernetes-aws-java:

    error: Running program [PID: 39496](/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java -classpath /opt/homebrew/Cellar/maven/3.9.9/libexec/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/opt/homebrew/Cellar/maven/3.9.9/libexec/bin/m2.conf -Dmaven.home=/opt/homebrew/Cellar/maven/3.9.9/libexec -Dlibrary.jansi.path=/opt/homebrew/Cellar/maven/3.9.9/libexec/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/Users/justin/Documents/2025/02/08/k8saws org.codehaus.plexus.classworlds.launcher.Launcher -Dorg.slf4j.simpleLogger.defaultLogLevel=warn --no-transfer-progress compile exec:java) failed with an unhandled exception:
    java.lang.UnsupportedOperationException: Convert [com.pulumi.eks.Cluster.core]: Error converting 'com.google.common.collect.RegularImmutableMap' to 'TypeShape{type=class com.pulumi.eks.outputs.CoreData, parameters=[]}'. Expected type 'com.pulumi.eks.outputs.CoreData' (annotated with 'com.pulumi.core.annotations.CustomType') to have a setter annotated with @com.pulumi.core.annotations.CustomType$Setter("autoModeNodeRoleName"), got: storageClasses,cluster,eksNodeAccess,vpcCni,encryptionConfig,nodeGroupOptions,nodeSecurityGroupTags,clusterIamRole,awsProvider,kubeconfig,tags,accessEntries,fargateProfile,endpoint,publicSubnetIds,oidcProvider,provider,instanceRoles,vpcId,clusterSecurityGroup,privateSubnetIds,subnetIds
        at com.pulumi.serialization.internal.Converter.convertObjectUntyped(Converter.java:119)
        at com.pulumi.serialization.internal.Converter.convertValue(Converter.java:86)
        at com.pulumi.core.internal.OutputCompletionSource.setValue(OutputCompletionSource.java:95)
        at com.pulumi.deployment.internal.DeploymentImpl$ReadOrRegisterResourceInternal.lambda$completeResourceAsync$1(DeploymentImpl.java:1359)
        at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:690)
        at java.base/java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:527)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1460)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2036)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:189)
    Caused by: java.lang.IllegalArgumentException: Expected type 'com.pulumi.eks.outputs.CoreData' (annotated with 'com.pulumi.core.annotations.CustomType') to have a setter annotated with @com.pulumi.core.annotations.CustomType$Setter("autoModeNodeRoleName"), got: storageClasses,cluster,eksNodeAccess,vpcCni,encryptionConfig,nodeGroupOptions,nodeSecurityGroupTags,clusterIamRole,awsProvider,kubeconfig,tags,accessEntries,fargateProfile,endpoint,publicSubnetIds,oidcProvider,provider,instanceRoles,vpcId,clusterSecurityGroup,privateSubnetIds,subnetIds
        at com.pulumi.serialization.internal.Converter.lambda$tryConvertObjectInner$5(Converter.java:315)
        at java.base/java.util.HashMap.forEach(HashMap.java:1430)
        at com.pulumi.serialization.internal.Converter.tryConvertObjectInner(Converter.java:313)
        at com.pulumi.serialization.internal.Converter.convertObjectUntyped(Converter.java:115)
        ... 9 more
    error: an unhandled error occurred: '/opt/homebrew/bin/mvn -Dorg.slf4j.simpleLogger.defaultLogLevel=warn --no-transfer-progress compile exec:java' exited with non-zero exit code: 32

    [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!

    Feb 08, 2025 10:20:35 AM com.pulumi.deployment.internal.DeploymentImpl$DefaultEngineLogger errorAsync
    SEVERE: Running program [PID: 39496](/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java -classpath /opt/homebrew/Cellar/maven/3.9.9/libexec/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/opt/homebrew/Cellar/maven/3.9.9/libexec/bin/m2.conf -Dmaven.home=/opt/homebrew/Cellar/maven/3.9.9/libexec -Dlibrary.jansi.path=/opt/homebrew/Cellar/maven/3.9.9/libexec/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/Users/justin/Documents/2025/02/08/k8saws org.codehaus.plexus.classworlds.launcher.Launcher -Dorg.slf4j.simpleLogger.defaultLogLevel=warn --no-transfer-progress compile exec:java) failed with an unhandled exception:
    java.lang.UnsupportedOperationException: Convert [com.pulumi.eks.Cluster.core]: Error converting 'com.google.common.collect.RegularImmutableMap' to 'TypeShape{type=class com.pulumi.eks.outputs.CoreData, parameters=[]}'. Expected type 'com.pulumi.eks.outputs.CoreData' (annotated with 'com.pulumi.core.annotations.CustomType') to have a setter annotated with @com.pulumi.core.annotations.CustomType$Setter("autoModeNodeRoleName"), got: storageClasses,cluster,eksNodeAccess,vpcCni,encryptionConfig,nodeGroupOptions,nodeSecurityGroupTags,clusterIamRole,awsProvider,kubeconfig,tags,accessEntries,fargateProfile,endpoint,publicSubnetIds,oidcProvider,provider,instanceRoles,vpcId,clusterSecurityGroup,privateSubnetIds,subnetIds
        at com.pulumi.serialization.internal.Converter.convertObjectUntyped(Converter.java:119)
        at com.pulumi.serialization.internal.Converter.convertValue(Converter.java:86)
        at com.pulumi.core.internal.OutputCompletionSource.setValue(OutputCompletionSource.java:95)
        at com.pulumi.deployment.internal.DeploymentImpl$ReadOrRegisterResourceInternal.lambda$completeResourceAsync$1(DeploymentImpl.java:1359)
        at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:690)
        at java.base/java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:527)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1460)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2036)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:189)
    Caused by: java.lang.IllegalArgumentException: Expected type 'com.pulumi.eks.outputs.CoreData' (annotated with 'com.pulumi.core.annotations.CustomType') to have a setter annotated with @com.pulumi.core.annotations.CustomType$Setter("autoModeNodeRoleName"), got: storageClasses,cluster,eksNodeAccess,vpcCni,encryptionConfig,nodeGroupOptions,nodeSecurityGroupTags,clusterIamRole,awsProvider,kubeconfig,tags,accessEntries,fargateProfile,endpoint,publicSubnetIds,oidcProvider,provider,instanceRoles,vpcId,clusterSecurityGroup,privateSubnetIds,subnetIds
        at com.pulumi.serialization.internal.Converter.lambda$tryConvertObjectInner$5(Converter.java:315)
        at java.base/java.util.HashMap.forEach(HashMap.java:1430)
        at com.pulumi.serialization.internal.Converter.tryConvertObjectInner(Converter.java:313)
        at com.pulumi.serialization.internal.Converter.convertObjectUntyped(Converter.java:115)

@justinvp justinvp marked this pull request as draft February 8, 2025 18:32
.portMappings(List.of(
TaskDefinitionPortMappingArgs.builder()
.containerPort(containerPort)
.targetGroup(loadbalancer.defaultTargetGroup())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the output that causes the issue. iirc wrapping this in pulumi.output(…) (or the java equivalent) is a way to work around this. I can give it a try later

.portMappings(List.of(
TaskDefinitionPortMappingArgs.builder()
.containerPort(containerPort)
.targetGroup(loadbalancer.defaultTargetGroup())
Copy link
Contributor

@flostadler flostadler Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me:

Suggested change
.targetGroup(loadbalancer.defaultTargetGroup())
.targetGroup(Output.of(loadbalancer.defaultTargetGroup()).apply(Function.identity()))

Note, this needs this import: import java.util.function.Function;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Florian mentioned in Slack, the workaround isn't actually working. We need to fix Java to serialize output values: pulumi/pulumi-java#1662. Working on this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port designated existing templates to Java
2 participants