Fix EKS autoMode preview with unknown values #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
t0yv0
reviewed
Jan 28, 2025
| // Make all eks auto mode options depend on the other options to ensure | ||
| // that they're all either known or unknown when auto mode is enabled. | ||
| const autoModeConfig = | ||
| args.autoMode?.enabled && computeConfig && storageConfig && kubernetesNetworkConfig |
t0yv0
approved these changes
Jan 28, 2025
The upstream EKS cluster resource requires that all auto mode settings are either enabled or disabled and does not handle unknown values. Make all eks auto mode options depend on the other options to ensure that they're all either known or unknown when auto mode is enabled.
flostadler
force-pushed
the
flostadler/auto-mode-preview
branch
from
cf3540c to
b23ce14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1603 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 2804 2804
======================================
Misses 2804 2804 ☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v3.8.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff customizer of the upstream provider is not taking possibly unknown values into account (see https://github.com/hashicorp/terraform-provider-aws/blob/ae93494f39ba70fe442e891caf05f8df21bde1ac/internal/service/eks/cluster.go#L1776-L1791), which causes failures like this one:
This happens because
unknownattributes just default to their empty values in a diff customizer if they're unknown .This change acts a hot fix until we can properly fix upstream's behavior here. The current diff for auto mode is quite broken and needs some more involved fixes (see hashicorp/terraform-provider-aws#40582).
Fixes #1597