Removing "No Operand in Assignment" Usage

[confused-Techie]

With PPM now properly setup on Codacy, the next two biggest suggestions are the following:

• No Unused Vars: For this one I've added a small bit of configuration to the eslint config file, to not apply this rule if the variable begins with an underscore, which should solve solve that issue by and large for us.
• No Assignment in Operand: This issue is less invasive than it appears. While there are some instances where variables are assigned a value within an operand, other situations were found such as old CoffeeScript is not operators that weren't decaffed cleanly, and also a single instance of what appears to be a typo of = rather than ==

With this issues addressed, we don't expect to see any change in hope behavior ourselves.

[DeeDeeG]

Overall looking good, I think this one change is meant to be assignment not comparison, though.

Thanks for doing this, IMO these complicated lines really do make more sense separated into more lines.

[DeeDeeG]

You'll probably be surprised why this was failing the tests: the actual function name in this file has been getIntalledPackage (note the typo, a missing "s" in "intalled") this whole time, since 2014 (atom/apm@c8d61000#diff-0aa64babcef87ba238fed061035f2fe14c587092a7339b55c5e4033c37370d70R46).

(Regarding the singular getIntalledPackage, not to be confused with the plural getInstalledPackages ("Packages") which has/had no typo.)

So, we can either revert the spelling here to the previous (typoed but defined) function name here, or rename the function elsewhere in the file that this line calls, so as to not have a typo in its name, lol.

But yeah, this broke tests by fixing a typo, I honestly did not see that coming.

Thanks again for working on this! Nice to see readability improvements to the code!!!!!! We sure need it, as debugging this PR has helped prove, IMO!!! Thank you!

[DeeDeeG]

Yeeeeeeeeeaaaaaaaaaah 😎

let's do it

(More readable code that at least mostly makes sense is both a good thing and has historically been all too rare in ppm repo. We've come a long way!!!!!!!)