[spatz_vlsu] added fix for indexed loads, verified with fft kernel #206
reviewdog [verible-verilog-lint] report
reported by reviewdog 🐶
Findings (30)
hw/ip/spatz/src/spatz_vrf.sv|159 col 12| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|284 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|287 col 29| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|288 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|292 col 87| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|298 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|307 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|331 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|335 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|339 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_controller.sv|434 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|77 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|108 col 45| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|110 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|130 col 26| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|356 col 24| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|363 col 129| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|382 col 24| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz.sv|389 col 140| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_vlsu.sv|446 col 31| Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9])+(_[0-9]+)?) [Style: constants] [parameter-name-style]
hw/ip/spatz/src/spatz_vlsu.sv|495 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_vlsu.sv|499 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_vlsu.sv|500 col 109| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_vlsu.sv|506 col 8| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/ip/spatz/src/spatz_vlsu.sv|692 col 31| Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9])+([0-9]+)?) [Style: constants] [parameter-name-style]
hw/ip/spatz/src/spatz_vlsu.sv|730 col 31| Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+([0-9]+)?) [Style: constants] [parameter-name-style]
hw/ip/spatz/src/spatz_vlsu.sv|1056 col 31| Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]
hw/system/spatz_cluster/src/spatz_tcdm_interconnect.sv|77 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/system/spatz_cluster/src/spatz_tcdm_interconnect.sv|79 col 28| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
hw/system/spatz_cluster/src/spatz_tcdm_interconnect.sv|84 col 1| Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Filtered Findings (0)
Annotations
Check warning on line 159 in hw/ip/spatz/src/spatz_vrf.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vrf.sv#L159
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_vrf.sv" range:{start:{line:159 column:12}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:159 column:12} end:{line:160}} text:" end\n"}
Check warning on line 284 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L284
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:284 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:284 column:1} end:{line:287}} text:"\n automatic logic intID;\n\n"}
Check warning on line 287 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L287
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:287 column:29}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 288 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L288
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:288 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 292 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L292
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:292 column:87}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:292 column:87} end:{line:293}} text:" end else if (port inside {SB_VLSU_VD_RD0, SB_VLSU_VD_RD1, SB_VLSU_VD_WD1}) begin\n"}
Check warning on line 298 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L298
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:298 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:298 column:1} end:{line:299}} text:"\n"}
Check warning on line 307 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L307
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:307 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:307 column:1} end:{line:308}} text:"\n"}
Check warning on line 331 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L331
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:331 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:331 column:1} end:{line:332}} text:"\n"}
Check warning on line 335 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L335
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:335 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:335 column:1} end:{line:336}} text:"\n"}
Check warning on line 339 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L339
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:339 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:339 column:1} end:{line:340}} text:"\n"}
Check warning on line 434 in hw/ip/spatz/src/spatz_controller.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_controller.sv#L434
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_controller.sv" range:{start:{line:434 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:434 column:1} end:{line:435}} text:"\n"}
Check warning on line 77 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L77
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:77 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:77 column:1} end:{line:78}} text:"\n"}
Check warning on line 108 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L108
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:108 column:45}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:108 column:45} end:{line:110}} text:" logic [$clog2(FpuBufDepth)-1:0] buf_usage;\n\n"}
Check warning on line 110 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L110
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:110 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 130 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L130
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:130 column:26}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:130 column:26} end:{line:131}} text:" vrf_buf_t vrf_buf_data;\n"}
Check warning on line 356 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L356
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:356 column:24}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:356 column:24} end:{line:357}} text:" .flush_i (1'b0),\n"}
Check warning on line 363 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L363
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:363 column:129}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:363 column:129} end:{line:364}} text:" .data_i ({vrf_wdata[VFU_VD_WD], vrf_waddr[VFU_VD_WD], vrf_wbe[VFU_VD_WD], sb_id[SB_VFU_VD_WD], vfu_rsp, vfu_rsp_valid}),\n"}
Check warning on line 382 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L382
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:382 column:24}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:382 column:24} end:{line:383}} text:" .flush_i (1'b0),\n"}
Check warning on line 389 in hw/ip/spatz/src/spatz.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz.sv#L389
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz.sv" range:{start:{line:389 column:140}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:389 column:140} end:{line:390}} text:" .data_i ({vrf_wdata[VLSU_VD_WD1], vrf_waddr[VLSU_VD_WD1], vrf_wbe[VLSU_VD_WD1], sb_id[SB_VLSU_VD_WD1], vlsu_rsp, vlsu_rsp_buf_en}),\n"}
Check warning on line 446 in hw/ip/spatz/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vlsu.sv#L446
Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]
Raw output
message:"Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]" location:{path:"hw/ip/spatz/src/spatz_vlsu.sv" range:{start:{line:446 column:31}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 495 in hw/ip/spatz/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vlsu.sv#L495
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_vlsu.sv" range:{start:{line:495 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:495 column:1} end:{line:496}} text:"\n"}
Check warning on line 499 in hw/ip/spatz/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vlsu.sv#L499
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_vlsu.sv" range:{start:{line:499 column:1}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:499 column:1} end:{line:501}} text:"\n // The second interface starts from half of the vector to straighten the write-back VRF access pattern\n"}
Check warning on line 500 in hw/ip/spatz/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vlsu.sv#L500
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_vlsu.sv" range:{start:{line:500 column:109}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}
Check warning on line 506 in hw/ip/spatz/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vlsu.sv#L506
Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]" location:{path:"hw/ip/spatz/src/spatz_vlsu.sv" range:{start:{line:506 column:8}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"} suggestions:{range:{start:{line:506 column:8} end:{line:507}} text:" end\n"}
Check warning on line 692 in hw/ip/spatz/src/spatz_vlsu.sv
github-actions / verible-verilog-lint
[verible-verilog-lint] hw/ip/spatz/src/spatz_vlsu.sv#L692
Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]
Raw output
message:"Localparam name does not match the naming convention defined by regex pattern: (([A-Z0-9]+[a-z0-9]*)+(_[0-9]+)?) [Style: constants] [parameter-name-style]" location:{path:"hw/ip/spatz/src/spatz_vlsu.sv" range:{start:{line:692 column:31}}} severity:WARNING source:{name:"verible-verilog-lint" url:"https://github.com/chipsalliance/verible"}