Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icache with bugfixes from injection testing #83

Open
wants to merge 1 commit into
base: astral
Choose a base branch
from

Conversation

micprog
Copy link
Member

@micprog micprog commented Jul 31, 2024

  • Updates icache with necessary bugfixes
  • Updates AXI and common_cells dependencies
  • Adds net extraction for icache state
  • Updates regression tests with test for astral icache with fault injection

@micprog micprog requested a review from yvantor July 31, 2024 11:07
@alex96295
Copy link
Collaborator

@belanoa same question: is the updated version of the icache from this PR already used in #87 ?

@belanoa
Copy link

belanoa commented Dec 19, 2024

@belanoa same question: is the updated version of the icache from this PR already used in #87 ?

No, it's not used. I'll apply the changes

Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

Comment on lines +10 to +11
revision: 587355b77b8ce94dcd600efbd5d5bd118ff913a7
version: 0.39.4
Copy link
Contributor

@yvantor yvantor Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember 0.39.4 has a killer bug, I saw in the upstream the release was modified to be the same as 0.39.5, but here we are pointing to the wrong commit (see here].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants