Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a True Multiprotcol DMA Engine #22

Closed
wants to merge 34 commits into from
Closed

Conversation

thommythomaso
Copy link
Collaborator

No description provided.

@thommythomaso thommythomaso added the enhancement New feature or request label Dec 20, 2022
@thommythomaso thommythomaso self-assigned this Dec 20, 2022
.ci/gitlab-ci.yml.tpl Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
Bender.yml Outdated Show resolved Hide resolved
@@ -64,49 +53,24 @@ sources:
- files: # 64bit descriptor frontend
# Level 0
- src/frontends/desc64/idma_desc64_reg_pkg.sv
# Level 1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create sub-bender files for the frontends and the systems. @thommythomaso

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@@ -0,0 +1,182 @@
# Copyright 2022 ETH Zurich and University of Bologna.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This database format needs to be documented. Both in-file and in a dedicated md file.

// Tobias Senti <[email protected]>

/// A byte-granular buffer holding data while it is copied.
module idma_dataflow_element #(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to include the user signals discussed

@@ -0,0 +1,132 @@
// Copyright 2022 ETH Zurich and University of Bologna.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move this to common cells.

if (not_bursting_i) begin
page_addr_width = OffsetWidth;
end else begin
// should the "virtual" page be reduced? e.g. the transfers split into
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add this as a parameter, but tbh I don't think its too much worth.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave it in this first version

@@ -0,0 +1,74 @@
// Copyright 2022 ETH Zurich and University of Bologna.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should replace this with a common cells implementation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that.

@@ -0,0 +1,585 @@
#!/usr/env python3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a bit more doc?

Copy link
Collaborator Author

@thommythomaso thommythomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments:

  • Move stream fifo to the comment cells version
  • Remove the axi submodule

@TheMightyDuckOfDoom TheMightyDuckOfDoom self-assigned this Dec 21, 2022
thommythomaso added a commit that referenced this pull request Oct 24, 2023
* treewide: Create a True Multiprotcol DMA Engine #22

* treewide: Various cleanup and moderinazion passes

---------

Co-authored-by: Tobias Senti <[email protected]>
thommythomaso added a commit that referenced this pull request Oct 24, 2023
* treewide: Create a True Multiprotocol DMA Engine #22

* treewide: Various cleanup and modernization passes

---------

Co-authored-by: Tobias Senti <[email protected]>
@thommythomaso
Copy link
Collaborator Author

Thank @TheMightyDuckOfDoom for your contributions. It will be merged as part of #36. Closed.

thommythomaso added a commit that referenced this pull request Oct 27, 2023
* treewide: Create a True Multiprotocol DMA Engine #22

* treewide: Various cleanup and modernization passes

---------

Co-authored-by: Tobias Senti <[email protected]>
@thommythomaso thommythomaso deleted the 0_5_prev-tbenz branch December 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants