Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source / sink modules for replication for error detection. #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lynx005F
Copy link

@Lynx005F Lynx005F commented Jul 1, 2024

This PR adds two modules to "copy" a HCI stream so that a secundary HCI network can be built for error detection on both control and data. These modules can work together with similar modules for HWPE-Stream, where the Idea is explained more in detail pulp-platform/hwpe-stream#21

Currently the PR only implements the "copy" variety (see HWPE PR for definition) of replication modules. For the redundancy in RedMulE this is the only module required.
If the other varieties could be usefull elsewhere I could implement them as well, but since they would result in different parameterizations of HCI for the copy network as existing modules would have to be looked at too, while copy is "safe" with respect to other modules.

@FrancescoConti FrancescoConti self-assigned this Jul 2, 2024
@Lynx005F Lynx005F force-pushed the itemm/parity_canary branch from bf48bb8 to 14e7df8 Compare July 3, 2024 10:04
@Lynx005F Lynx005F marked this pull request as ready for review July 8, 2024 08:23
@Lynx005F
Copy link
Author

Lynx005F commented Jul 8, 2024

I merged all different options into one file and added a type selection enum. Potentially there are other types of duplication that could also be implemented, but for RedMulE this covers everything needed.

@Lynx005F Lynx005F force-pushed the itemm/parity_canary branch from 14e7df8 to 5a9eee0 Compare July 29, 2024 11:53
Copy link

@LuigiGhionda LuigiGhionda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants