add stream_fifo: fifo_v3 with rdy/vld interface

[da-gazzi]

Just a trivial wrapper for fifo_v3 - I found it handy to have around.

[zarubaf]

Thanks for your contribution. I have a couple of comments and requests for changes. We adhere to the SystemVerilog coding style of lowrisc. You might want to look into this as well.

[zarubaf]

Could you also add an entry in the CHANGELOG.md, to Bender.yml and to the README.md please. Thanks!

[da-gazzi]

I fixed most of your requests - the alignment is still a bit out of whack comparing to other modules in this repo; this is due to me using a different editor (and not being able to get sublime text to make it look somewhat reasonable).

[andreaskurth]

Thanks for your PR, @da-gazzi, this is certainly a useful addition!

the alignment is still a bit out of whack comparing to other modules in this repo; this is due to me using a different editor (and not being able to get sublime text to make it look somewhat reasonable).

I do not see how your editor has more influence on exactly which characters you put into a file than you do. Every plain text editor I have used allows me to exactly set individual ASCII characters. ;-)

I took the liberty to add a few commits that make this PR compliant to our coding conventions. Most importantly, never use tabs. You can pull those commits from the stream_fifo branch (I pushed them there since I did not want -- and probably would not be able -- to push to your master).

[da-gazzi]

Thanks for your PR, @da-gazzi, this is certainly a useful addition!

the alignment is still a bit out of whack comparing to other modules in this repo; this is due to me using a different editor (and not being able to get sublime text to make it look somewhat reasonable).

I do not see how your editor has more influence on exactly which characters you put into a file than you do. Every plain text editor I have used allows me to exactly set individual ASCII characters. ;-)

I took the liberty to add a few commits that make this PR compliant to our coding conventions. Most importantly, never use tabs. You can pull those commits from the stream_fifo branch (I pushed them there since I did not want -- and probably would not be able -- to push to your master).

Thanks for the fixes! I have applied and pushed them to my fork. It should now be ready for merging.

What I meant by my remark regarding editors was that my editor does not "auto-indent" things the same way e.g. sublime text does, which I assume to be the editor of choice for all the prominent contributors to these repositories. Of course I can manually put spaces wherever I please, but in the interest of my own mental well-being I avoid this. I go with whatever the editor I'm using does by default. I will do my best to adhere to the style guide in future pull requests, of course ;)

By the way, it seems the tabs were actually added by sublime text in my unsuccessful attempts to find an easy way to automatically "conformalize" the code style - I know I won't do that again!

[andreaskurth]

Thanks for the fixes! I have applied and pushed them to my fork. It should now be ready for merging.

Thanks, LGTM.

What I meant by my remark regarding editors was that my editor does not "auto-indent" things the same way e.g. sublime text does, which I assume to be the editor of choice for all the prominent contributors to these repositories. Of course I can manually put spaces wherever I please, but in the interest of my own mental well-being I avoid this. I go with whatever the editor I'm using does by default. I will do my best to adhere to the style guide in future pull requests, of course ;)

AFAIK, most of us use different editors (Sublime, Vim, VS Code, ..), but plugins such as EditorConfig make it easy to automatically have a consistent style. Which reminds me: Should we add a .editorconfig to this repo, @zarubaf?

[zarubaf]

Thanks. Yes, let's add the editorconfig in a separate PR. I'll open an issue for that.