Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HW: Refactor Cluster integration #24

Merged
merged 5 commits into from
Aug 19, 2024
Merged

HW: Refactor Cluster integration #24

merged 5 commits into from
Aug 19, 2024

Conversation

Scheremo
Copy link
Collaborator

@Scheremo Scheremo commented Aug 14, 2024 •
edited
Loading

Extracts the clusters from chimera_top_wrapper to chimera_clu_domain and chimera_cluster.
Also reconfigures all adapters to minimize AXI ID widths.

Added

  • chimera_clu_domain which wraps cluster instantiation
  • chimera_cluster which instantiates a single cluster and all necessary adapters

Changed

  • Cluster's Narrow AXI ID width is now converted to width 1
  • Wide AXI ID width is now converted to width 1
  • Offload API now takes into account possibly varying numbers of cores per cluster

@Scheremo Scheremo requested review from micprog and Lore0599 August 14, 2024 13:32
@Scheremo Scheremo force-pushed the convolve branch 4 times, most recently from 71eff43 to fe7cfa9 Compare August 16, 2024 15:18
@Scheremo Scheremo marked this pull request as ready for review August 19, 2024 07:13
micprog
micprog reviewed Aug 19, 2024
View reviewed changes
hw/bootrom/snitch/snitch_startup.c Show resolved Hide resolved
hw/chimera_clu_domain.sv Show resolved Hide resolved
hw/chimera_clu_domain.sv Show resolved Hide resolved
hw/chimera_cluster.sv Show resolved Hide resolved
hw/chimera_cluster.sv Show resolved Hide resolved
hw/chimera_cluster_adapter.sv Outdated Show resolved Hide resolved
hw/chimera_cluster_adapter.sv Outdated Show resolved Hide resolved
hw/chimera_cluster_adapter.sv Outdated Show resolved Hide resolved
hw/chimera_cluster_adapter.sv Outdated Show resolved Hide resolved
hw/chimera_pkg.sv Outdated Show resolved Hide resolved
@micprog micprog mentioned this pull request Aug 19, 2024
Open
micprog
micprog approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some review comments moved to an issue (#30), LGTM 👍

@Scheremo Scheremo merged commit 9d5c562 into devel Aug 19, 2024
6 checks passed
@Scheremo Scheremo deleted the convolve branch August 19, 2024 13:09
sermazz pushed a commit that referenced this pull request Oct 23, 2024
@Scheremo @sermazz
HW: Refactor Cluster integration (#24)
c230213 
* HW: Refactor Cluster integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micprog micprog micprog approved these changes

@Lore0599 Lore0599 Awaiting requested review from Lore0599

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scheremo @micprog