Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bender.lock to reflect updated memory island dependency #17

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

Scheremo
Copy link
Collaborator

Updated the Bender.lock file

@micprog
Copy link
Member

micprog commented Jul 26, 2024

I see that some bender dependencies point to branch names: This can quickly lead to incompatibilities, e.g., when branches update with breaking changes. Versions are suggested, tags are a reasonable alternative (tags should always stay fixed), and commit hashes are, in my opinion, a necessary evil, but still better than branch names that can update, including breaking changes, without warning. I see this is the case here for cheshire and snitch_cluster. Other than this, the update looks good to me.

@Scheremo
Copy link
Collaborator Author

Scheremo commented Jul 26, 2024

I see that some bender dependencies point to branch names: This can quickly lead to incompatibilities, e.g., when branches update with breaking changes. Versions are suggested, tags are a reasonable alternative (tags should always stay fixed), and commit hashes are, in my opinion, a necessary evil, but still better than branch names that can update, including breaking changes, without warning. I see this is the case here for cheshire and snitch_cluster. Other than this, the update looks good to me.

Should be fixed now!

Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Scheremo
Copy link
Collaborator Author

LGTM 👍

I further changed the CVA6 URL to use https for consistency :)

@micprog
Copy link
Member

micprog commented Jul 26, 2024

LGTM 👍

I further changed the CVA6 URL to use https for consistency :)

That's a good call, thanks! I could argue in cheshire you're still pointing to a branch of cva6, but fine for me right now, I just recommend to update when you get around to it.

@Scheremo Scheremo merged commit 3c80b07 into devel Jul 26, 2024
2 of 9 checks passed
@Scheremo Scheremo deleted the scheremo/publicMemoryIsland branch July 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants