Multihead support for ITA #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeratec
requested review from
SamuelRiedel,
viv-eth and
paulsc96
as code owners
viv-eth
requested changes
Feb 28, 2024
Xeratec
force-pushed
the
pr/ita_multihead
branch
from
c2f1e81 to
4ea3844
Compare
Features - Added configuration file for MemPool with ITA Changes - ITA: Load RQS parameter from memory - ITA: Support user specified output address for results - ITA: Support different matrix shapes - ITA: Support 32-bit row-vise biases - ITA: Fetch Q and K always from ITA Core 0 Fix - ITA: Fix overflow bug in streaming_partial_softmax Important Note The softmax values have a maximum value of 127 as `sumdot` modules of the hardware can only do signed-signed operations for now. This is a temporary fix until `sumdot` is fixed.
Xeratec
force-pushed
the
pr/ita_multihead
branch
from
4ea3844 to
d4e204f
Compare
viv-eth
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for MHSA with ITA by decoupling the four ITA cores in MemPool and supporting different input matrix shapes (without precisely modelling the tiling of the hardware). Furthermore, it introduces fetching the requantization parameter from memory and specifying the location of the computation result by the user.
Finally, to reduce the generated output when running Banshee in debug mode, I propose to remove the log outputs for aligned and unaligned
memcpyoperation as well as switching from debug to trace messages for some very frequently produced messages.Features
Changes
Fix
Important Note
The softmax values have a maximum value of 127 as
sumdotmodules of the hardware can only do signed-signed operations for now. This is a temporary fix untilsumdotis fixed.