Add erb-lint with github accessibility rules

Removed title from a tag to satisfy: The title attribute should never be used for an a tag Co-authored-by: Jane Sandberg <[email protected]> Co-authored-by: Liz Garcia <[email protected]>
pulibrary · Sep 26, 2023 · c260ec0 · c260ec0
1 parent 7364b07
commit c260ec0
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 1 deletion.
diff --git a/.erb-lint.yml b/.erb-lint.yml
@@ -0,0 +1,5 @@
+---
+EnableDefaultLinters: false
+inherit_gem:
+  erblint-github:
+    - config/accessibility.yml
diff --git a/.erb-linters/erblint-github.rb b/.erb-linters/erblint-github.rb
@@ -0,0 +1 @@
+require "erblint-github/linters"
diff --git a/Gemfile b/Gemfile
@@ -118,6 +118,8 @@ group :development, :test do
   gem 'bixby', '~> 5.0'
   gem 'capybara'
   gem 'coveralls_reborn'
+  gem "erb_lint", require: false
+  gem "erblint-github"
   gem 'pry-byebug'
   gem 'solargraph'
 end
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -123,6 +123,13 @@ GEM
     bcrypt (3.1.19)
     bcrypt_pbkdf (1.1.0)
     benchmark (0.2.1)
+    better_html (2.0.2)
+      actionview (>= 6.0)
+      activesupport (>= 6.0)
+      ast (~> 2.0)
+      erubi (~> 1.4)
+      parser (>= 2.4)
+      smart_properties
     bixby (5.0.2)
       rubocop (= 1.28.2)
       rubocop-ast
@@ -231,6 +238,14 @@ GEM
     ed25519 (1.3.0)
     email_validator (2.2.4)
       activemodel
+    erb_lint (0.5.0)
+      activesupport
+      better_html (>= 2.0.1)
+      parser (>= 2.7.1.4)
+      rainbow
+      rubocop
+      smart_properties
+    erblint-github (0.4.1)
     erubi (1.12.0)
     execjs (2.8.1)
     factory_bot (6.2.1)
@@ -526,6 +541,7 @@ GEM
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
     slop (4.10.1)
+    smart_properties (1.17.0)
     sneakers (2.11.0)
       bunny (~> 2.12)
       concurrent-ruby (~> 1.0)
@@ -668,6 +684,8 @@ DEPENDENCIES
   devise-guests (~> 0.5)
   ed25519
   email_validator
+  erb_lint
+  erblint-github
   factory_bot_rails
   faker
   faraday (~> 0.17)

diff --git a/app/views/shared/_header_navbar.html.erb b/app/views/shared/_header_navbar.html.erb
@@ -4,7 +4,7 @@
     <div class="container">
       <div class="row align-items-center">
         <div class="logo__pul col-12 col-sm-auto">
-          <a href="https://library.princeton.edu" title="Princeton University Library">
+          <a href="https://library.princeton.edu">
              <%= image_tag("pul-logo-new.svg", alt: "Link to Princeton University Library home page") %>
           </a>
           <%=link_to t('blacklight.orangelight').html_safe, main_app.root_path, :class => "site-title" %>