[LuxMenuBar] If no href is supplied, use a <button> tag instead of an <a> tag #410
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… <a> tag Prior to this commit, if you don't supply an href value for a child menu item, Lux will render an <a> tag without an href. This is not focusable, so keyboard users will not be able to activate that menu item. This helps with pulibrary/allsearch_frontend#443, since it allows us to create menu items that are keyboard focusable that are not links (in this case, they will be buttons that switch between dark mode and light mode).
kevinreiss
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if you don't supply an href value for a child menu item, Lux will render an tag without an href. This is not focusable, so keyboard users will not be able to activate that menu item.
This helps with pulibrary/allsearch_frontend#443, since it allows us to create menu items that are keyboard-focusable that are not links (in this case, they will be buttons that switch between dark mode and light mode).