Set up wallaby and add a feature test #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container Scanning Status: ✅ Success |
hackartisan
force-pushed
the
311-wallaby
branch
4 times, most recently
from
103b386 to
a753afd
Compare
Followed the instructions in the wallaby readme, using chromdriver because that seems to be the most common setup that works well for people, based on looking around the elixir forum I added a new mix alias for running tests in ci because you have to ensure that js is built otherwise liveview stuff doesn't work. there may be a day when we need to also add the css assets? Finally, I skipped everything in the setup about running tests async and ensuring database connections don't mess with one another. We may need to do that stuff at some point. Note that failing feature tests will add a screenshot artifact closes #311
hackartisan
force-pushed
the
311-wallaby
branch
from
3ecdc25 to
8fc3fe9
Compare
tpendragon
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed the instructions in the wallaby readme, using chromdriver
because that seems to be the most common setup that works well for
people, based on looking around the elixir forum
I added a new mix alias for running tests in ci because you have to
ensure that js is built otherwise liveview stuff doesn't work. there may
be a day when we need to also add the css assets?
Finally, I skipped everything in the setup about running tests async and
ensuring database connections don't mess with one another. We may need
to do that stuff at some point.
Note that failing feature tests will add a screenshot artifact
closes #311