Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete records linked to deletion markers #317

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Delete records linked to deletion markers #317

merged 12 commits into from
Feb 19, 2025

Conversation

eliotjordan
Copy link
Member

@eliotjordan eliotjordan commented Feb 14, 2025 •
edited
Loading

  • Delete solr documents linked to deletion markers
  • Remove hydration and transformation cache entries for deleted items

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Container Scanning Status: ✅ Success


ghcr.io/pulibrary/dpul-collections:pr-317 (debian 12.6)
=======================================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@eliotjordan eliotjordan changed the title Delete records linked to deletion markers* Delete records linked to deletion markers Feb 14, 2025
@eliotjordan eliotjordan force-pushed the 102-deletes branch 2 times, most recently from af32e94 to 75a57d3 Compare February 18, 2025 16:17
@eliotjordan
Copy link
Member Author

Tested in staging. Deleting a test EphemeraFolder in Figgy caused the corresponding record to be removed from DPUL-C.

@eliotjordan eliotjordan force-pushed the 102-deletes branch 2 times, most recently from 1704da2 to 42feb1e Compare February 18, 2025 19:24
@eliotjordan eliotjordan marked this pull request as ready for review February 18, 2025 19:27
tpendragon
tpendragon requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tpendragon tpendragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, just a couple questions.

hackartisan
hackartisan requested changes Feb 19, 2025
View reviewed changes
hackartisan
hackartisan requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing!

lib/dpul_collections/indexing_pipeline/figgy/transformation_consumer.ex Outdated
handled_data: solr_doc
})
end

def handle_message(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they're so similar, it would be nice to have a comment saying why we are keeping both. I'm thinking it's so we can filter out things that aren't ephemera folders?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hackartisan I previously removed that transformation consumer function. No changes made to this file in the PR currently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, browser stuff I guess. Okay!

@hackartisan hackartisan merged commit 94bf233 into main Feb 19, 2025
4 checks passed
@hackartisan hackartisan deleted the 102-deletes branch February 19, 2025 20:41
@hackartisan hackartisan mentioned this pull request Feb 20, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan approved these changes

@tpendragon tpendragon tpendragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliotjordan @hackartisan @tpendragon