bump v2.4.9; indigenous lands layer fix for one-line constructor; commenting in AllLayers.js

[jywarren]

Fixed indigenous lands layers in one-liner constructor

Some progress on labeling AllLayers.js - #665

Also - going to merge despite test failures, which have developed as APIs have changed, as has the data they return.

[gitpod-io]

[jywarren]

  Purple layer - markers
  ✓ adds markers on click (1310ms)
  ✓ should have the layer name added to the hash
  ✓ has default markers in default mode
  1) has circle markers in minimal mode
  2) shows popup
  3) removes markers from the map and the layer name from the hash when clicked again
 3 passing (12s)
  3 failing
  1) Purple layer - markers
       has circle markers in minimal mode:
     AssertionError: Timed out retrying: Expected to find element: `.leaflet-overlay-pane svg g`, but never found it.
      at Context.eval (http://localhost:8080/__cypress/tests?p=cypress/integration/purpleAirMarker.spec.js:33:10)
  2) Purple layer - markers
       shows popup:
     AssertionError: Timed out retrying: Expected to find element: `.leaflet-overlay-pane svg g`, but never found it.
      at Context.eval (http://localhost:8080/__cypress/tests?p=cypress/integration/purpleAirMarker.spec.js:41:8)
  3) Purple layer - markers
       removes markers from the map and the layer name from the hash when clicked again:
     TypeError: The following error originated from your application code, not from Cypress.

[jywarren]

OK, the cypress tests aren't generally doing very well;

#662 fails a ton and is unrelated to this PR

Feb '21 - Here's where we had set up GitHub Actions originally: #503

Aug '21 - We haven't merged anything significant since #569 when cypress passed.

Dec '21 - This is prob the most recent PR that did NOT fail: #587 / https://github.com/publiclab/leaflet-environmental-layers/runs/3719417244?check_suite_focus=true

Some of these could be related to specific layers source data actually failing. To be honest, the PurpleAir markers being the only one that fails is kind of surprising if that's the case. A lot of other layers sources could have changed or their APIs could be down...

Whaaaaaa... ok, the most recent run, a lot more failed - incl:

Aqicn layer
       has circle markers in minimal mode:
AssertionError: Timed out retrying: Too many elements found. Found '1143', expected '2'.

could this be an index error where the new layer displaced an old one, or maybe AQICN now actually lists 1143 markers for the given region?

---

  1) FractrackerMobile layer
       has circle markers in minimal mode:
     AssertionError: Timed out retrying: Expected to find element: ``, but never found it. Queried from element: <g>
      at Context.eval (http://localhost:8080/__cypress/tests?p=cypress/integration/fractrackerMobile.spec.js:37:56)
  2) FractrackerMobile layer
       shows popup:
     AssertionError: Timed out retrying: Expected to find element: ``, but never found it. Queried from element: <g>
      at Context.eval (http://localhost:8080/__cypress/tests?p=cypress/integration/fractrackerMobile.spec.js:47:43)

OK, I'm going to manually check:

1. the same tests in other recently failing PRs
2. the demo to see if those layers are working and if not, why?

[jywarren]

Yes, similar or same test failures also occur in most other PRs - tracking at #668 and will resolve there.

[jywarren]

Ok, I've confirmed manually that the "indigenous lands" layer works!

[jywarren]

See #668 for test failures next steps; they are unrelated to this PR's content.