Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct JPG saving #42

Merged
merged 3 commits into from
Apr 20, 2020
Merged

direct JPG saving #42

merged 3 commits into from
Apr 20, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Apr 10, 2020

re #36

@jywarren
Copy link
Member Author

Hmm. What am I doing wrong here?

    2) should send response
  2 passing (2m)
  2 failing
  1) /GET /ap1/v2/export
       should send response:
     Error: Timeout of 100000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/app/test/process.js)

https://travis-ci.org/github/publiclab/image-sequencer-app/builds/673562138#L1288

This was referenced Apr 14, 2020
@tech4GT
Copy link
Member

tech4GT commented Apr 19, 2020

@jywarren This looks good to me! 😃
I think the tests are failing not because of the content of this PR. I'll modify the tests and maybe you can pull the changes in on this?

@tech4GT
Copy link
Member

tech4GT commented Apr 19, 2020

I see! Since we changed the API the tests can't really test this version anymore! Let me temporarily comment out our tests until we can figure out an efficient way of testing this out!

@tech4GT
Copy link
Member

tech4GT commented Apr 19, 2020

Okay done! I think we can merge this in directly!

@jywarren
Copy link
Member Author

OK, i'll rebase this!

@jywarren jywarren merged commit fad302f into main Apr 20, 2020
@jywarren
Copy link
Member Author

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants