allow supplying images JSON directly as "collection" POST data #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywarren
commented
Dec 5, 2019
| console.log("Export endpoint hit for url " + url); | ||
| require("axios").get(url).then(redirectToProcess); | ||
| } else { // supplying JSON for images directly: | ||
| redirectToProcess(req.query.collection); |
There was a problem hiding this comment.
I don't think we have to parse the JSON, right?
|
Great! Let's add a test with some json! image-sequencer-app/test/process.js Line 54 in 892c1ba |
|
Modified in response to this; although the test did not fail? |
|
The new test worked, as far as I can see! #34 will help but merging for now. |
|
Ah, oops! I need to bump the version number. New PR. |
|
Published |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match https://github.com/publiclab/mapknitter-exporter-sinatra#usage
Fixes #32 i hope!