Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump woofmark from 12e2c1d to 39237b7" #602

Closed

Conversation

keshav234156
Copy link
Member

Reverts #597

@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2020

@jywarren
Copy link
Member

Hi @keshav234156 can you explain this a little more? Thank you!

@keshav234156
Copy link
Member Author

@jywarren tests were failing #597 https://travis-ci.com/github/publiclab/PublicLab.Editor/jobs/372642656#L255
So that why created a revert PR

@jywarren
Copy link
Member

Yes, however, can you explain why they were failing? And, given that those are updates we really want from woofmark, and they passed tests originally before I merged that, what do you think we should do next? Thank you so much, Keshav!

@sagarpreet-chadha
Copy link
Contributor

Hey @keshav234156 , the tests in other PR's should also fail, right?
But they seem to be passing in #600

@jywarren
Copy link
Member

jywarren commented Sep 1, 2020

I think I'll close this as #600 indeed seems to show this is not an issue! Thank you!!

@jywarren jywarren closed this Sep 1, 2020
@keshav234156
Copy link
Member Author

keshav234156 commented Sep 1, 2020

I think I'll close this as #600 indeed seems to show this is not an issue! Thank you!!

I don't think think so. Errors can be seen here as well https://travis-ci.com/github/publiclab/PublicLab.Editor/jobs/379516209. #600 migh not have been rebased that why it's not showing errors. I was not able to find the reason but it is due to this PR.

@jywarren
Copy link
Member

jywarren commented Sep 1, 2020

Oh, i see - ok, we need to document this carefully. @keshav234156 moving to #607 cc @sagarpreet-chadha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants