-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies update #412
Merged
Merged
Dependencies update #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6a0c4f
to
163d254
Compare
4faa692
to
83dcbe8
Compare
rexagod
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
sashadev-sky
added a commit
that referenced
this pull request
Sep 15, 2019
* update dist * update dependencies * stop using jQuery in DistortableImage.Edit * move exif and glfx to dependencies * update installation instructions * try again fix node error * update travis
themacboy
pushed a commit
to themacboy/Leaflet.DistortableImage
that referenced
this pull request
Sep 19, 2019
* update dist * update dependencies * stop using jQuery in DistortableImage.Edit * move exif and glfx to dependencies * update installation instructions * try again fix node error * update travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
=======
changes:
exif-js
,webgl-distort
, andglfx
todependencies
leaflet
topeerDependencies
grunt-cli
todevDependencies
.. wasn't positive about this one but looked through Github to see what other repos do and that seems to be the consensusDistortableImage.Edit.js
. I don't think we need to have jQuery as a dependency in this library so removing some of it now. Will remove the rest after exporting is fixed and then remove jQuery dependency.README
installation instructionstravis.yml
=======