Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies update #412

Merged
merged 7 commits into from
Aug 28, 2019
Merged

Dependencies update #412

merged 7 commits into from
Aug 28, 2019

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Aug 28, 2019

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

=======

changes:

  • move exif-js, webgl-distort, and glfx to dependencies
  • move leaflet to peerDependencies
  • move grunt-cli to devDependencies .. wasn't positive about this one but looked through Github to see what other repos do and that seems to be the consensus
  • convert jQuery code to native DOM in DistortableImage.Edit.js. I don't think we need to have jQuery as a dependency in this library so removing some of it now. Will remove the rest after exporting is fixed and then remove jQuery dependency.
  • update README installation instructions
  • update travis.yml
    =======

@sashadev-sky sashadev-sky requested a review from rexagod August 28, 2019 06:04
@sashadev-sky
Copy link
Member Author

@rexagod I took the dependency update chunk out of your EXIF PR (#169), updated it, and made some other changes. Let me know if this is ok to merge!

Copy link
Member

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@sashadev-sky sashadev-sky merged commit 4f2d87d into publiclab:main Aug 28, 2019
@sashadev-sky sashadev-sky deleted the dependencies branch August 28, 2019 23:37
sashadev-sky added a commit that referenced this pull request Sep 15, 2019
* update dist

* update dependencies

* stop using jQuery in DistortableImage.Edit

* move exif and glfx to dependencies

* update installation instructions

* try again fix node error

* update travis
themacboy pushed a commit to themacboy/Leaflet.DistortableImage that referenced this pull request Sep 19, 2019
* update dist

* update dependencies

* stop using jQuery in DistortableImage.Edit

* move exif and glfx to dependencies

* update installation instructions

* try again fix node error

* update travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants